-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(design): add sorting way based on regexps #2379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/@o3r/design/src/core/design-token/renderers/design-token-style.renderer.ts
Outdated
Show resolved
Hide resolved
mrednic-1A
reviewed
Oct 31, 2024
packages/@o3r/design/builders/generate-style/helpers/style-renderer-options.ts
Show resolved
Hide resolved
mrednic-1A
previously approved these changes
Oct 31, 2024
kpanot
force-pushed
the
feature/design-sorting
branch
from
October 31, 2024 09:02
44024b0
to
d9a8d2a
Compare
packages/@o3r/design/src/core/design-token/renderers/design-token-style.renderer.ts
Show resolved
Hide resolved
kpanot
force-pushed
the
feature/design-sorting
branch
from
October 31, 2024 09:31
d9a8d2a
to
89b9581
Compare
fpaul-1A
reviewed
Oct 31, 2024
packages/@o3r/design/src/core/design-token/renderers/design-token-style.renderer.spec.ts
Outdated
Show resolved
Hide resolved
fpaul-1A
reviewed
Oct 31, 2024
packages/@o3r/design/src/core/design-token/renderers/design-token-style.renderer.ts
Outdated
Show resolved
Hide resolved
fpaul-1A
reviewed
Oct 31, 2024
packages/@o3r/design/builders/generate-style/helpers/style-renderer-options.ts
Outdated
Show resolved
Hide resolved
kpanot
force-pushed
the
feature/design-sorting
branch
from
October 31, 2024 14:05
89b9581
to
6e5407d
Compare
kpanot
force-pushed
the
feature/design-sorting
branch
from
October 31, 2024 14:22
6e5407d
to
7034f66
Compare
fpaul-1A
approved these changes
Oct 31, 2024
matthieu-crouzet
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add a way to sort variables based on provided RegExps
Related issues
- No issue associated -